Skip to content

Add missing Simplified Chinese (zh-CN) translations for dags, components, admin - #70419

Merged
Lee-W merged 3 commits into
apache:v3-3-testfrom
1fanwang:zh-cn-i18n-misc
Jul 29, 2026
Merged

Add missing Simplified Chinese (zh-CN) translations for dags, components, admin#70419
Lee-W merged 3 commits into
apache:v3-3-testfrom
1fanwang:zh-cn-i18n-misc

Conversation

@1fanwang

@1fanwang 1fanwang commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Fill missing zh-CN UI strings for the 3.3.1 RC: run-state filters, duration-chart total, partition-key helper, and variable import progress. $t()/{{placeholders}} preserved.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

GitHub Copilot CLI following the guidelines

This was human verified by myself (native simplified Chinese writer) before posting.

@boring-cyborg boring-cyborg Bot added area:translations area:UI Related to UI/UX. For Frontend Developers. translation:zh-CN labels Jul 24, 2026
Comment thread airflow-core/src/airflow/ui/public/i18n/locales/zh-CN/admin.json
Comment thread airflow-core/src/airflow/ui/public/i18n/locales/zh-CN/dags.json
Comment thread airflow-core/src/airflow/ui/public/i18n/locales/zh-CN/dags.json
Comment thread airflow-core/src/airflow/ui/public/i18n/locales/zh-CN/admin.json
…nts, admin

Fill the zh-CN gap for the 3.3.1 RC: run-state filter labels, duration-chart total, partition-key helper, and variable import progress. $t()/{{placeholders}} preserved.

Signed-off-by: 1fanwang <1fannnw@gmail.com>
@1fanwang
1fanwang marked this pull request as ready for review July 24, 2026 21:38
@1fanwang
1fanwang requested a review from potiuk as a code owner July 24, 2026 21:38
1fanwang added 2 commits July 25, 2026 21:23
The English 'Parsing file...' and the sibling loading strings keep the
trailing ellipsis, so 正在解析文件 should too.

Signed-off-by: 1fanwang <1fannnw@gmail.com>
The English values are 'Any run', 'Last run', and 'Total: {{duration}}';
the earlier zh-CN added 状态/中位数/时长 that the source labels don't carry.

Signed-off-by: 1fanwang <1fannnw@gmail.com>

@Lee-W Lee-W left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really in a position to judge the accuracy, but at least nothing looks incorrect to me. Approved. Thanks!

@potiuk potiuk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical approval — translation-only change. JSON is valid, key parity with en is exact in both directions, {{...}} placeholders and $t() references are preserved, and key ordering follows the existing convention. This is not a review of the language quality itself.


This review was drafted by an AI-assisted tool and
confirmed by an Airflow maintainer. The maintainer
approving this PR has read the findings and signed off. If
something feels off, please reply on the PR and a maintainer
will follow up.

More on how Airflow handles maintainer review:
contributing-docs/05_pull_requests.rst.


Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

@potiuk

potiuk commented Jul 26, 2026

Copy link
Copy Markdown
Member

Thanks for these three — all approved for v3-3-test.

One follow-up worth doing while the context is fresh. All three PRs (#70417, #70418, #70419) target v3-3-test only, and the same gaps are still open on main. Comparing en against zh-CN there as of today:

namespace missing keys
common 64
dashboard 10
hitl 8
dags 7
components 2
admin 1

That's 92 keys — more than these PRs add here, because main has picked up newer English strings on top of the ones you're filling for 3.3.1.

The consequence is that these translations ship in 3.3.1 and then go missing again in 3.4, since 3.4 releases from main. Every other translation effort currently in flight targets main — Polish (#70476), Arabic (#70383), Korean (#70211), French (#70386) — and French additionally opened #70387 as its v3-3-test counterpart, which is the pattern worth copying: land on main first, then backport to the release branch. Right now zh-CN is the only language going release-branch-only.

Nothing to change on these three — they're good for the RC. But could you open a companion PR against main covering the same namespaces? The full 92-key set would be ideal, though even porting just what's in these three would be a clear improvement. If you'd rather not take it on, let us know and we can look for someone else to pick it up.


Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

@Lee-W
Lee-W merged commit 875ac49 into apache:v3-3-test Jul 29, 2026
83 checks passed
@github-actions github-actions Bot added this to the Airflow 3.3.2 milestone Jul 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.3.2 based on: merged to version branch
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

@vatsrahul1001 vatsrahul1001 added the type:doc-only Changelog: Doc Only label Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:translations area:UI Related to UI/UX. For Frontend Developers. translation:zh-CN type:doc-only Changelog: Doc Only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants